diff options
| author | Andrew Clayton <a.clayton@nginx.com> | 2023-03-23 20:16:08 +0000 |
|---|---|---|
| committer | Andrew Clayton <a.clayton@nginx.com> | 2023-03-28 23:15:28 +0100 |
| commit | c1303660eda80c5e17fde06bb8f17715e7be049b (patch) | |
| tree | 6604e5d93ef42ce3ced9c5cf8d4dc2ee24bd5170 /src/nxt_http_parse.h | |
| parent | f20172e5959d2029fdc7f084a332a748563dd50e (diff) | |
| download | unit-c1303660eda80c5e17fde06bb8f17715e7be049b.tar.gz unit-c1303660eda80c5e17fde06bb8f17715e7be049b.tar.bz2 | |
Convert uint8_t struct boolean members to nxt_bool_t.
Replace the usage of uint8_t in structures to represent boolean values
with our nxt_bool_t type.
This will result in no change in structure layout as the nxt_bool_t is
now a uint8_t, same as what it's replacing.
Even though it's essentially the same type, it makes it much clearer as
to what its purpose is.
This was largely done with the following script from Alex, with some
manual conversions
$ grep -rl 'uint8_t.*1 bit' src/ \
| xargs sed -i '/uint8_t.*1 bit/{s/uint8_t /nxt_bool_t /;s/; *\/\*.*/;/}'
This doesn't convert the non-uint8_t booleans, they will be handled
separately.
Reviewed-by: Alejandro Colomar <alx@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
Diffstat (limited to 'src/nxt_http_parse.h')
| -rw-r--r-- | src/nxt_http_parse.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/src/nxt_http_parse.h b/src/nxt_http_parse.h index 2b714464..4aa1c258 100644 --- a/src/nxt_http_parse.h +++ b/src/nxt_http_parse.h @@ -55,19 +55,19 @@ struct nxt_http_request_parse_s { uint32_t field_hash; - uint8_t skip_field; /* 1 bit */ - uint8_t discard_unsafe_fields; /* 1 bit */ + nxt_bool_t skip_field; + nxt_bool_t discard_unsafe_fields; /* target with "/." */ - uint8_t complex_target; /* 1 bit */ + nxt_bool_t complex_target; #if 0 /* target with "%" */ - uint8_t quoted_target; /* 1 bit */ + nxt_bool_t quoted_target; /* target with " " */ - uint8_t space_in_target; /* 1 bit */ + nxt_bool_t space_in_target; #endif /* Preserve encoded '/' (%2F) and '%' (%25). */ - uint8_t encoded_slashes; /* 1 bit */ + nxt_bool_t encoded_slashes; }; @@ -101,9 +101,9 @@ typedef struct { uint64_t chunk_size; uint8_t state; - uint8_t last; /* 1 bit */ - uint8_t chunk_error; /* 1 bit */ - uint8_t error; /* 1 bit */ + nxt_bool_t last; + nxt_bool_t chunk_error; + nxt_bool_t error; } nxt_http_chunk_parse_t; |
