diff options
| author | Maxim Dounin <mdounin@mdounin.ru> | 2012-02-04 23:18:12 +0000 |
|---|---|---|
| committer | Maxim Dounin <mdounin@mdounin.ru> | 2012-02-04 23:18:12 +0000 |
| commit | e646c6a946869f8a5a2507cbbc1452f61a13dfc5 (patch) | |
| tree | 2748504902aa7f058cc3ef4b0c991755693560f5 /src | |
| parent | b720407a891df8dd0b85995b8059c6f6d7649248 (diff) | |
| download | nginx-e646c6a946869f8a5a2507cbbc1452f61a13dfc5.tar.gz nginx-e646c6a946869f8a5a2507cbbc1452f61a13dfc5.tar.bz2 | |
Merge of r4306, r4320:
Protection from stale write events in epoll.
Stale write event may happen if epoll_wait() reported both read and write
events, and processing of the read event closed descriptor.
Diffstat (limited to 'src')
| -rw-r--r-- | src/event/modules/ngx_epoll_module.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/src/event/modules/ngx_epoll_module.c b/src/event/modules/ngx_epoll_module.c index 31c10c6dc..f4003af70 100644 --- a/src/event/modules/ngx_epoll_module.c +++ b/src/event/modules/ngx_epoll_module.c @@ -683,6 +683,18 @@ ngx_epoll_process_events(ngx_cycle_t *cycle, ngx_msec_t timer, ngx_uint_t flags) if ((revents & EPOLLOUT) && wev->active) { + if (c->fd == -1 || wev->instance != instance) { + + /* + * the stale event from a file descriptor + * that was just closed in this iteration + */ + + ngx_log_debug1(NGX_LOG_DEBUG_EVENT, cycle->log, 0, + "epoll: stale event %p", c); + continue; + } + if (flags & NGX_POST_THREAD_EVENTS) { wev->posted_ready = 1; |
