summaryrefslogtreecommitdiffhomepage
path: root/src
diff options
context:
space:
mode:
authorIgor Sysoev <igor@sysoev.ru>2011-11-01 11:23:26 +0000
committerIgor Sysoev <igor@sysoev.ru>2011-11-01 11:23:26 +0000
commit1b6bed1c8e0652e133155c323a3fdd56f3fb31c3 (patch)
tree74155fba8c77ee024673af26ca983e01b6efb9c1 /src
parentf59e9d45fb8ee216dd7db6a723a7912c012e4b5b (diff)
downloadnginx-1b6bed1c8e0652e133155c323a3fdd56f3fb31c3.tar.gz
nginx-1b6bed1c8e0652e133155c323a3fdd56f3fb31c3.tar.bz2
Merging r4013, r4200:
error_log related fixes: *) Complain on invalid log levels. Previously only first log level was required to be correct, while error_log directive in fact accepts list of levels (e.g. one may specify "error_log ... debug_core debug_http;"). This resulted in (avoidable) wierd behaviour on missing semicolon after error_log directive, e.g. error_log /path/to/log info index index.php; silently skipped index directive and it's arguments (trying to interpret them as log levels without checking to be correct). *) Fixed configuration summary and manpage contents for the special --error-log-path=stderr case.
Diffstat (limited to 'src')
-rw-r--r--src/core/ngx_log.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/src/core/ngx_log.c b/src/core/ngx_log.c
index 44333146d..e7d597e7e 100644
--- a/src/core/ngx_log.c
+++ b/src/core/ngx_log.c
@@ -369,12 +369,13 @@ ngx_log_create(ngx_cycle_t *cycle, ngx_str_t *name)
char *
ngx_log_set_levels(ngx_conf_t *cf, ngx_log_t *log)
{
- ngx_uint_t i, n, d;
+ ngx_uint_t i, n, d, found;
ngx_str_t *value;
value = cf->args->elts;
for (i = 2; i < cf->args->nelts; i++) {
+ found = 0;
for (n = 1; n <= NGX_LOG_DEBUG; n++) {
if (ngx_strcmp(value[i].data, err_levels[n].data) == 0) {
@@ -387,7 +388,8 @@ ngx_log_set_levels(ngx_conf_t *cf, ngx_log_t *log)
}
log->log_level = n;
- continue;
+ found = 1;
+ break;
}
}
@@ -401,11 +403,13 @@ ngx_log_set_levels(ngx_conf_t *cf, ngx_log_t *log)
}
log->log_level |= d;
+ found = 1;
+ break;
}
}
- if (log->log_level == 0) {
+ if (!found) {
ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
"invalid log level \"%V\"", &value[i]);
return NGX_CONF_ERROR;