diff options
| author | Roman Arutyunyan <arut@nginx.com> | 2023-09-14 14:13:43 +0400 |
|---|---|---|
| committer | Roman Arutyunyan <arut@nginx.com> | 2023-09-14 14:13:43 +0400 |
| commit | 26e606a6bcdfa4001bfb6bd24612e8aafa6513b2 (patch) | |
| tree | 0d9e251b38169d4c8b0aade70e5874cfedee9c29 /src/http/v3/ngx_http_v3.c | |
| parent | 6ecf576e34c3780b6cdb3f509c89042aa411e3d2 (diff) | |
| download | nginx-26e606a6bcdfa4001bfb6bd24612e8aafa6513b2.tar.gz nginx-26e606a6bcdfa4001bfb6bd24612e8aafa6513b2.tar.bz2 | |
HTTP/3: postponed session creation to init() callback.
Now the session object is assigned to c->data while ngx_http_connection_t
object is referenced by its http_connection field, similar to
ngx_http_v2_connection_t and ngx_http_request_t.
The change allows to eliminate v3_session field from ngx_http_connection_t.
The field was under NGX_HTTP_V3 macro, which was a source of binary
compatibility problems when nginx/module is build with/without HTTP/3 support.
Postponing is essential since c->data should retain the reference to
ngx_http_connection_t object throughout QUIC handshake, because SSL callbacks
ngx_http_ssl_servername() and ngx_http_ssl_alpn_select() rely on this.
Diffstat (limited to 'src/http/v3/ngx_http_v3.c')
| -rw-r--r-- | src/http/v3/ngx_http_v3.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/http/v3/ngx_http_v3.c b/src/http/v3/ngx_http_v3.c index eb86b2da5..8db229b29 100644 --- a/src/http/v3/ngx_http_v3.c +++ b/src/http/v3/ngx_http_v3.c @@ -30,6 +30,8 @@ ngx_http_v3_init_session(ngx_connection_t *c) goto failed; } + h3c->http_connection = hc; + ngx_queue_init(&h3c->blocked); h3c->keepalive.log = c->log; @@ -48,7 +50,7 @@ ngx_http_v3_init_session(ngx_connection_t *c) cln->handler = ngx_http_v3_cleanup_session; cln->data = h3c; - hc->v3_session = h3c; + c->data = h3c; return NGX_OK; |