diff options
| author | Vladimir Homutov <vl@nginx.com> | 2021-11-18 14:19:36 +0300 |
|---|---|---|
| committer | Vladimir Homutov <vl@nginx.com> | 2021-11-18 14:19:36 +0300 |
| commit | e165526e43d60b9249690faccbb380be20e88af3 (patch) | |
| tree | 66fd7c7f600713662c28f8ddce897144ea0f8f58 /src/event/quic/ngx_event_quic_socket.c | |
| parent | 1688afd955e02b4a12ddf394b42a132e5e4daffc (diff) | |
| download | nginx-e165526e43d60b9249690faccbb380be20e88af3.tar.gz nginx-e165526e43d60b9249690faccbb380be20e88af3.tar.bz2 | |
QUIC: fixed handling of RETIRE_CONNECTION_ID frame.
Previously, the retired socket was not closed if it didn't match
active or backup.
New sockets could not be created (due to count limit), since retired socket
was not closed before calling ngx_quic_create_sockets().
When replacing retired socket, new socket is only requested after closing
old one, to avoid hitting the limit on the number of active connection ids.
Together with added restrictions, this fixes an issue when a current socket
could be closed during migration, recreated and erroneously reused leading
to null pointer dereference.
Diffstat (limited to 'src/event/quic/ngx_event_quic_socket.c')
| -rw-r--r-- | src/event/quic/ngx_event_quic_socket.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/event/quic/ngx_event_quic_socket.c b/src/event/quic/ngx_event_quic_socket.c index ddde68f09..3b507fca8 100644 --- a/src/event/quic/ngx_event_quic_socket.c +++ b/src/event/quic/ngx_event_quic_socket.c @@ -14,8 +14,6 @@ static ngx_int_t ngx_quic_create_temp_socket(ngx_connection_t *c, ngx_quic_connection_t *qc, ngx_str_t *dcid, ngx_quic_path_t *path, ngx_quic_client_id_t *cid); -static void ngx_quic_unref_path(ngx_connection_t *c, ngx_quic_path_t *path); - ngx_int_t ngx_quic_open_sockets(ngx_connection_t *c, ngx_quic_connection_t *qc, @@ -207,7 +205,7 @@ ngx_quic_close_socket(ngx_connection_t *c, ngx_quic_socket_t *qsock) } -static void +void ngx_quic_unref_path(ngx_connection_t *c, ngx_quic_path_t *path) { ngx_quic_connection_t *qc; |