unit.git - Universal Web Application Server

Age	Commit message (Collapse)	Author	Files	Lines
2025-03-20	Tag various character arrays with NXT_NONSTRING	Andrew Clayton	1	-2/+2
	In Unit we have a number of character arrays which are intentionally not NUL terminated. With GCC 15 this static const char hex[16] = "0123456789ABCDEF"; will trigger a warning like $ gcc -Wextra -c nonstring.c nonstring.c: In function ‘hexit’: nonstring.c:9:37: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (17 chars into 16 available) [-Wunterminated-string-initialization] 9 \| static const char hex[16] = "0123456789ABCDEF"; \| ^~~~~~~~~~~~~~~~~~ By adding NXT_NONSTRING like static const char hex[16] NXT_NONSTRING = "0123456789ABCDEF"; we no longer get the warning. Cc: Alejandro Colomar <alx@kernel.org> Co-authored-by: Alejandro Colomar <alx@kernel.org> Signed-off-by: Alejandro Colomar <alx@kernel.org> Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
2023-10-10	Refactored nxt_vsprintf().	Zhidao HONG	1	-9/+8

2022-06-01	Logging a NULL pointer instead of passing it in the memcpy().	Andrei Zeliankou	1	-9/+19

2022-05-26	Added const to remove unnecessary casts.	Alejandro Colomar	1	-5/+5
	Casts are usually very dangerous, disabling most compiler warnings and basically removing type safety. This change adds 'const' to a pointer where we don't need to write, improving type safety, and that also allows removing some casts.
2022-05-03	Fixed #define style.	Alejandro Colomar	1	-2/+1
	We had a mix of styles for declaring function-like macros: Style A: #define \ foo() \ do { \ ... \ } while (0) Style B: #define foo() \ do { \ ... \ } while (0) We had a similar number of occurences of each style: $ grep -rnI '^\w(.\\' \| wc -l 244 $ grep -rn 'define.(.)' \| wc -l 239 (Those regexes aren't perfect, but a very decent approximation.) Real examples: $ find src -type f \| xargs sed -n '/^nxt_double_is_zero/,/^$/p' nxt_double_is_zero(f) \ (fabs(f) <= FLT_EPSILON) $ find src -type f \| xargs sed -n '/define nxt_http_field_set/,/^$/p' #define nxt_http_field_set(_field, _name, _value) \ do { \ (_field)->name_length = nxt_length(_name); \ (_field)->value_length = nxt_length(_value); \ (_field)->name = (u_char ) _name; \ (_field)->value = (u_char ) _value; \ } while (0) I'd like to standardize on a single style for them, and IMO, having the identifier in the same line as #define is a better option for the following reasons: - Programmers are used to `#define foo() ...` (readability). - One less line of code. - The program for finding them is really simple (see below). function grep_ngx_func() { if (($# != 1)); then >&2 echo "Usage: ${FUNCNAME[0]} <func>"; return 1; fi; find src -type f \ \| grep '\.[ch]$' \ \| xargs grep -l "$1" \ \| sort \ \| xargs pcregrep -Mn "(?s)^\$[\w\s]+?^$1\(.?^}"; find src -type f \ \| grep '\.[ch]$' \ \| xargs grep -l "$1" \ \| sort \ \| xargs pcregrep -Mn "(?s)define $1\(.?^$" \ \| sed -E '1s/^[^:]+:[0-9]+:/&\n\n/'; } $ grep_ngx_func Usage: grep_ngx_func <func> $ grep_ngx_func nxt_http_field_set src/nxt_http.h:98: #define nxt_http_field_set(_field, _name, _value) \ do { \ (_field)->name_length = nxt_length(_name); \ (_field)->value_length = nxt_length(_value); \ (_field)->name = (u_char ) _name; \ (_field)->value = (u_char ) _value; \ } while (0) $ grep_ngx_func nxt_sprintf src/nxt_sprintf.c:56: u_char nxt_cdecl nxt_sprintf(u_char buf, u_char end, const char fmt, ...) { u_char p; va_list args; va_start(args, fmt); p = nxt_vsprintf(buf, end, fmt, args); va_end(args); return p; } ................ Scripted change: ................ $ find src -type f \ \| grep '\.[ch]$' \ \| xargs sed -i '/define \\$/{N;s/ \\\n/ /;s/ //}'
2019-09-19	Basic support for serving static files.	Valentin Bartenev	1	-2/+2

2019-03-11	Style.	Andrey Zelenkov	1	-6/+6

2018-06-25	Removed '\r' and '\n' artifact macros.	Igor Sysoev	1	-1/+1

2018-06-25	Introduced nxt_length() macro.	Valentin Bartenev	1	-2/+2

2018-04-04	Style: capitalized letters in hexadecimal literals.	Valentin Bartenev	1	-3/+3

2018-01-24	Using size_t for the field width type of the "%*s" specifier.	Sergey Kandaurov	1	-1/+1

2017-09-27	Fixed building with pthread_t defined as a pointer.	Sergey Kandaurov	1	-1/+1

2017-09-22	Removed fibers from compilation.	Valentin Bartenev	1	-2/+2
	It's not used anyway, but breaks building with musl. This closes issue #5 on GitHub.
2017-06-23	Style and comment fixes.	Igor Sysoev	1	-1/+1

2017-02-01	nxt_str_t changes.	Igor Sysoev	1	-17/+17