unit.git/src, branch applog

Handle log-rotation for the per-application logs.

2023-04-06T18:42:22+00:00

This commit makes the per-applications logs (if set) partake in logfile
rotation. This occurs when the master unit process receives a SIGUSR1.

Reviewed-by: Alejandro Colomar 
Signed-off-by: Andrew Clayton

Add per-application logging.

2023-04-06T18:42:22+00:00

This adds main part of per-application logging.

Currently when running in the foreground, unit application processes
will send stdout to the current TTY and stderr to the unit log file.

That behaviour won't change.

When running as a daemon, unit application processes will send stdout to
/dev/null and stderr to the unit log file.

This commit allows to alter the latter case of unit running as a daemon,
by allowing applications to redirect stdout and/or stderr to specific
log files. This is done via two new application options, 'stdout' &
'stderr', e.g

  "applications": {
      "myapp": {
          ...
          "stdout": "/path/to/log/unit/app/stdout.log",
          "stderr": "/path/to/log/unit/app/stderr.log"
      }
  }

These log files are created by the application processes themselves and
thus the log directories need to be writable by the user (and or group)
of the application processes.

E.g

  $ sudo mkdir -p /path/to/log/unit/app
  $ sudo chown APP_USER /path/to/log/unit/app

These need to be setup before starting unit with the above config.

NOTE:

You may or may not see stuff printed to stdout as stdout was
traditionally used by CGI applications to communicate with the
webserver.

Closes: 
Closes: 
Reviewed-by: Alejandro Colomar 
Signed-off-by: Andrew Clayton

Add nxt_file_stdout().

2023-04-06T18:42:16+00:00

This is analogous to the nxt_file_stderr() function and will be used in
a subsequent commit.

This function redirects stdout to a given file descriptor.

Reviewed-by: Alejandro Colomar 
Signed-off-by: Andrew Clayton

Remove a useless assignment in nxt_mem_zone_alloc_pages().

2023-04-03T13:53:04+00:00

This was reported by the 'Clang Static Analyzer' as a 'dead nested
assignment'.

We assign prev_size then check if it's != 0 and if true we then set
prev_pages to page_size right shifted by two at the same time setting
prev_size to be right shifted by two (>>=), however page_size is never
used again so no need to set it here.

Reviewed-by: Alejandro Colomar 
Signed-off-by: Andrew Clayton

Prevent a possible NULL de-reference in nxt_job_create().

2023-04-03T13:53:04+00:00

We allocate 'job' we then have a check if it's not NULL and do stuff
with it, but then we accessed it outside this check.

Simply return if job is NULL.

Reviewed-by: Alejandro Colomar 
Signed-off-by: Andrew Clayton

Remove a useless assignment in nxt_fs_mkdir_all().

2023-04-03T13:53:04+00:00

This was reported by the 'Clang Static Analyzer' as a 'dead nested
assignment'.

We set end outside the loop but the first time we use it is to assign it
in the loop (not used anywhere else).

Further cleanup could be to reduce the scope of end by moving its
declaration inside the loop.

Reviewed-by: Alejandro Colomar 
Signed-off-by: Andrew Clayton

Auto: mirroring installation structure in build tree.

2023-03-28T22:41:08+00:00

This makes the build tree more organized, which is good for adding new
stuff.  Now, it's useful for example for adding manual pages in man3/,
but it may be useful in the future for example for extending the build
system to run linters (e.g., clang-tidy(1), Clang analyzer, ...) on the
C source code.

Previously, the build tree was quite flat, and looked like this (after
`./configure && make`):

    $ tree -I src build
    build
    ├── Makefile
    ├── autoconf.data
    ├── autoconf.err
    ├── echo
    ├── libnxt.a
    ├── nxt_auto_config.h
    ├── nxt_version.h
    ├── unitd
    └── unitd.8

    1 directory, 9 files

And after this patch, it looks like this:

    $ tree -I src build
    build
    ├── Makefile
    ├── autoconf.data
    ├── autoconf.err
    ├── bin
    │   └── echo
    ├── include
    │   ├── nxt_auto_config.h
    │   └── nxt_version.h
    ├── lib
    │   ├── libnxt.a
    │   └── unit
    │       └── modules
    ├── sbin
    │   └── unitd
    ├── share
    │   └── man
    │       └── man8
    │           └── unitd.8
    └── var
        ├── lib
        │   └── unit
        ├── log
        │   └── unit
        └── run
            └── unit

    17 directories, 9 files

It also solves one issue introduced in
5a37171f733f ("Added default values for pathnames.").  Before that
commit, it was possible to run unitd from the build system
(`./build/unitd`).  Now, since it expects files in a very specific
location, that has been broken.  By having a directory structure that
mirrors the installation, it's possible to trick it to believe it's
installed, and run it from there:

    $ ./configure --prefix=./build
    $ make
    $ ./build/sbin/unitd

Fixes: 5a37171f733f ("Added default values for pathnames.")
Reported-by: Liam Crilly 
Reviewed-by: Konstantin Pavlov 
Reviewed-by: Andrew Clayton 
Cc: Andrei Zeliankou 
Cc: Zhidao Hong 
Signed-off-by: Alejandro Colomar

Renamed --libstatedir to --statedir.

2023-03-28T22:40:40+00:00

In BSD systems, it's usually  or some other dir under 
that is not , so $statedir is a more generic name.  See
hier(7).

Reported-by: Andrei Zeliankou 
Reported-by: Zhidao Hong 
Reviewed-by: Konstantin Pavlov 
Reviewed-by: Andrew Clayton 
Cc: Liam Crilly 
Signed-off-by: Alejandro Colomar

HTTP: added route logging.

2023-03-21T12:02:38+00:00

-  Configuration: added "/config/settings/http/log_route".

   Type: bool
   Default: false

   This adds configurability to the error log.  It allows enabling and
   disabling logs related to how the router performs selection of the
   routes.

-  HTTP: logging request line.

   Log level: [notice]

   The request line is essential to understand which logs correspond to
   which request when reading the logs.

-  HTTP: logging route that's been discarded.

   Log level: [info]

-  HTTP: logging route whose action is selected.

   Log level: [notice]

-  HTTP: logging when "fallback" action is taken.

   Log level: [notice]

Closes: 
Link: 
Link: 
Suggested-by: Timo Stark 
Suggested-by: Mark L Wood-Patrick 
Suggested-by: Liam Crilly 
Tested-by: Liam Crilly 
Acked-by: Artem Konev 
Cc: Andrew Clayton 
Cc: Andrei Zeliankou 
Reviewed-by: Zhidao Hong 
Signed-off-by: Alejandro Colomar

HTTP: rewrote while loop as for loop.

2023-03-21T12:02:38+00:00

This considerably simplifies the function, and will also help log the
iteration in which we are, which corresponds to the route array element.

Link: 
Link: 
Reviewed-by: Andrew Clayton 
Tested-by: Liam Crilly 
Reviewed-by: Zhidao Hong 
Signed-off-by: Alejandro Colomar