From db90ddcb9ed847b101ebb794bfadcd3ef829147c Mon Sep 17 00:00:00 2001
From: Sergey Kandaurov <pluknet@nginx.com>
Date: Wed, 22 Apr 2020 14:52:16 +0300
Subject: Improved ngx_quic_build_int() code and readability.

The function now generates somewhat shorter assembler after inlining.
---
 src/event/ngx_event_quic_transport.c | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

(limited to 'src')

diff --git a/src/event/ngx_event_quic_transport.c b/src/event/ngx_event_quic_transport.c
index 1a2cada35..19e7ba305 100644
--- a/src/event/ngx_event_quic_transport.c
+++ b/src/event/ngx_event_quic_transport.c
@@ -238,29 +238,23 @@ static void
 ngx_quic_build_int(u_char **pos, uint64_t value)
 {
     u_char      *p;
-    ngx_uint_t   len;//, len2;
+    ngx_uint_t   bits, len;
 
     p = *pos;
-    len = 0;
+    bits = 0;
 
-    while (value >> ((1 << len) * 8 - 2)) {
-        len++;
+    while (value >> ((8 << bits) - 2)) {
+        bits++;
     }
 
-    *p = len << 6;
+    len = (1 << bits);
 
-//    len2 =
-    len = (1 << len);
-    len--;
-    *p |= value >> (len * 8);
-    p++;
-
-    while (len) {
-        *p++ = value >> ((len-- - 1) * 8);
+    while (len--) {
+        *p++ = value >> (len * 8);
     }
 
+    **pos |= bits << 6;
     *pos = p;
-//    return len2;
 }
 
 
-- 
cgit