From bbbc80465bae44c4f9a1236683addbc51e7a8710 Mon Sep 17 00:00:00 2001 From: Roman Arutyunyan Date: Tue, 4 May 2021 13:38:59 +0300 Subject: HTTP/3: fixed decoder stream stubs. Now ngx_http_v3_ack_header() and ngx_http_v3_inc_insert_count() always generate decoder error. Our implementation does not use dynamic tables and does not expect client to send Section Acknowledgement or Insert Count Increment. Stream Cancellation, on the other hand, is allowed to be sent anyway. This is why ngx_http_v3_cancel_stream() does not return an error. --- src/http/v3/ngx_http_v3_tables.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/http/v3/ngx_http_v3_tables.c b/src/http/v3/ngx_http_v3_tables.c index 5389d0e2f..200e8a396 100644 --- a/src/http/v3/ngx_http_v3_tables.c +++ b/src/http/v3/ngx_http_v3_tables.c @@ -390,9 +390,9 @@ ngx_http_v3_ack_header(ngx_connection_t *c, ngx_uint_t stream_id) ngx_log_debug1(NGX_LOG_DEBUG_HTTP, c->log, 0, "http3 ack header %ui", stream_id); - /* XXX */ + /* we do not use dynamic tables */ - return NGX_OK; + return NGX_HTTP_V3_ERR_DECODER_STREAM_ERROR; } @@ -402,7 +402,7 @@ ngx_http_v3_cancel_stream(ngx_connection_t *c, ngx_uint_t stream_id) ngx_log_debug1(NGX_LOG_DEBUG_HTTP, c->log, 0, "http3 cancel stream %ui", stream_id); - /* XXX */ + /* we do not use dynamic tables */ return NGX_OK; } @@ -414,9 +414,9 @@ ngx_http_v3_inc_insert_count(ngx_connection_t *c, ngx_uint_t inc) ngx_log_debug1(NGX_LOG_DEBUG_HTTP, c->log, 0, "http3 increment insert count %ui", inc); - /* XXX */ + /* we do not use dynamic tables */ - return NGX_OK; + return NGX_HTTP_V3_ERR_DECODER_STREAM_ERROR; } -- cgit