From 7250a7688da4ee9ad1a88fd1489bbb19ec2020ce Mon Sep 17 00:00:00 2001 From: Vladimir Homutov Date: Wed, 7 Oct 2020 10:14:02 +0300 Subject: QUIC: fixed memory leak in ngx_quic_send_frames(). The function did not free passed frames in case of error. --- src/event/ngx_event_quic.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/event/ngx_event_quic.c') diff --git a/src/event/ngx_event_quic.c b/src/event/ngx_event_quic.c index c6a249b42..aff89b01d 100644 --- a/src/event/ngx_event_quic.c +++ b/src/event/ngx_event_quic.c @@ -3839,6 +3839,7 @@ ngx_quic_send_frames(ngx_connection_t *c, ngx_quic_send_ctx_t *ctx, len = ngx_quic_create_frame(p, f); if (len == -1) { + ngx_quic_free_frames(c, frames); return NGX_ERROR; } @@ -3897,11 +3898,13 @@ ngx_quic_send_frames(ngx_connection_t *c, ngx_quic_send_ctx_t *ctx, pkt.num_len, pkt.trunc); if (ngx_quic_encrypt(&pkt, ssl_conn, &res) != NGX_OK) { + ngx_quic_free_frames(c, frames); return NGX_ERROR; } len = c->send(c, res.data, res.len); if (len == NGX_ERROR || (size_t) len != res.len) { + ngx_quic_free_frames(c, frames); return NGX_ERROR; } -- cgit