From 96e36ef25243d7f49d821dbf8e47937ddbdea3f6 Mon Sep 17 00:00:00 2001
From: Igor Sysoev <igor@sysoev.ru>
Date: Sat, 12 Sep 2009 09:28:37 +0000
Subject: If .domain.com, .sub.domain.com, and .domain-some.com were defined,
 then .sub.domain.com was matched by .domain.com: wildcard names hash was
 built incorrectly due to sorting order issue of "." vs "-". They were sorted
 as     com.domain  com.domain-some  com.domain.sub while they should be
 sorted as     com.domain  com.domain.sub   com.domain-some for correct hash
 building

---
 src/core/ngx_string.c | 31 +++++++++++++++++++++++++++++++
 src/core/ngx_string.h |  1 +
 2 files changed, 32 insertions(+)

(limited to 'src/core')

diff --git a/src/core/ngx_string.c b/src/core/ngx_string.c
index c0bcc1d12..3456baa5c 100644
--- a/src/core/ngx_string.c
+++ b/src/core/ngx_string.c
@@ -819,6 +819,37 @@ ngx_memn2cmp(u_char *s1, u_char *s2, size_t n1, size_t n2)
 }
 
 
+ngx_int_t
+ngx_dns_strcmp(u_char *s1, u_char *s2)
+{
+    ngx_uint_t  c1, c2;
+
+    for ( ;; ) {
+        c1 = (ngx_uint_t) *s1++;
+        c2 = (ngx_uint_t) *s2++;
+
+        c1 = (c1 >= 'A' && c1 <= 'Z') ? (c1 | 0x20) : c1;
+        c2 = (c2 >= 'A' && c2 <= 'Z') ? (c2 | 0x20) : c2;
+
+        if (c1 == c2) {
+
+            if (c1) {
+                continue;
+            }
+
+            return 0;
+        }
+
+        /* in ASCII '.' > '-', but we need '.' to be the lowest character */
+
+        c1 = (c1 == '.') ? ' ' : c1;
+        c2 = (c2 == '.') ? ' ' : c2;
+
+        return c1 - c2;
+    }
+}
+
+
 ngx_int_t
 ngx_atoi(u_char *line, size_t n)
 {
diff --git a/src/core/ngx_string.h b/src/core/ngx_string.h
index 81e1ea169..0525b0e24 100644
--- a/src/core/ngx_string.h
+++ b/src/core/ngx_string.h
@@ -158,6 +158,7 @@ u_char *ngx_strlcasestrn(u_char *s1, u_char *last, u_char *s2, size_t n);
 ngx_int_t ngx_rstrncmp(u_char *s1, u_char *s2, size_t n);
 ngx_int_t ngx_rstrncasecmp(u_char *s1, u_char *s2, size_t n);
 ngx_int_t ngx_memn2cmp(u_char *s1, u_char *s2, size_t n1, size_t n2);
+ngx_int_t ngx_dns_strcmp(u_char *s1, u_char *s2);
 
 ngx_int_t ngx_atoi(u_char *line, size_t n);
 ssize_t ngx_atosz(u_char *line, size_t n);
-- 
cgit