From 14b1b6e10a75994a6001a3480901e62f43e05696 Mon Sep 17 00:00:00 2001 From: Piotr Sikora Date: Mon, 15 Aug 2016 05:52:04 -0700 Subject: Thread pools: create threads in detached state. This prevents theoretical resource leak, since those threads are never joined. Found with ThreadSanitizer. Signed-off-by: Piotr Sikora --- src/core/ngx_thread_pool.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/core/ngx_thread_pool.c b/src/core/ngx_thread_pool.c index f3655aa0b..7fb0f7f8d 100644 --- a/src/core/ngx_thread_pool.c +++ b/src/core/ngx_thread_pool.c @@ -137,6 +137,13 @@ ngx_thread_pool_init(ngx_thread_pool_t *tp, ngx_log_t *log, ngx_pool_t *pool) return NGX_ERROR; } + err = pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED); + if (err) { + ngx_log_error(NGX_LOG_ALERT, log, err, + "pthread_attr_setdetachstate() failed"); + return NGX_ERROR; + } + #if 0 err = pthread_attr_setstacksize(&attr, PTHREAD_STACK_MIN); if (err) { -- cgit