summaryrefslogtreecommitdiffhomepage
AgeCommit message (Collapse)AuthorFilesLines
2020-11-26Version bump.Ruslan Ermilov1-2/+2
2020-11-25HTTP/3: eliminated r->method_start.Roman Arutyunyan4-17/+14
The field was introduced to ease parsing HTTP/3 requests. The change reduces diff to the default branch.
2020-11-24release-1.19.5 tagMaxim Dounin1-0/+1
2020-11-24nginx-1.19.5-RELEASErelease-1.19.5Maxim Dounin1-0/+56
2020-11-18gRPC: RST_STREAM(NO_ERROR) handling after "trailer only" responses.Pavel Pautov1-0/+1
Similarly to the problem fixed in 2096b21fcd10 (ticket #1792), when a "trailer only" gRPC response (that is, a response with the END_STREAM flag in the HEADERS frame) was immediately followed by RST_STREAM(NO_ERROR) in the data preread along with the response header, RST_STREAM wasn't properly skipped and caused "upstream rejected request with error 0" errors. Observed with "unknown service" gRPC errors returned by grpc-go. Fix is to set ctx->done if we are going to parse additional data, so the RST_STREAM(NO_ERROR) is properly skipped. Additionally, now ngx_http_grpc_filter() will complain about frames sent for closed stream if there are any.
2020-11-19Use .Mt to mark up email addresses.Sergey Kandaurov1-2/+2
2020-11-19Core: "-e" command line option.Igor Ippolitov7-17/+68
When installing or running from a non-root user it is sometimes required to override default, compiled in error log path. There was no way to do this without rebuilding the binary (ticket #147). This patch introduced "-e" command line option which allows one to override compiled in error log path.
2020-11-17HTTP/3: null-terminate empty header value.Roman Arutyunyan1-0/+1
Header value returned from the HTTP parser is expected to be null-terminated or have a spare byte after the value bytes. When an empty header value was passed by client in a literal header representation, neither was true. This could result in segfault. The fix is to assign a literal empty null-terminated string in this case. Thanks to Andrey Kolyshkin.
2020-11-17HTTP/3: finalize chunked response body chain with NULL.Roman Arutyunyan1-0/+3
Unfinalized chain could result in segfault. The problem was introduced in ef83990f0e25. Patch by Andrey Kolyshkin.
2020-11-24Merged with the default branch.Sergey Kandaurov20-122/+338
2020-11-18QUIC: rejecting zero-length packets with PROTOCOL_VIOLATION.Sergey Kandaurov1-6/+15
Per the latest post draft-32 specification updates on the topic: https://github.com/quicwg/base-drafts/pull/4391
2020-11-17QUIC: simplified and streamlined ngx_quic_decrypt().Sergey Kandaurov1-11/+7
Both clearflags and badflags are removed. It makes a little sense now to keep them as intermediate storage.
2020-11-17QUIC: merged create_long/short_packet() functions.Sergey Kandaurov1-67/+3
They no longer differ.
2020-11-17QUIC: macros for manipulating header protection and reserved bits.Sergey Kandaurov2-15/+10
This gets rid of magic numbers from quic protection and allows to push down header construction specifics further to quic transport.
2020-11-17QUIC: hide header creation internals in ngx_event_quic_transport.c.Sergey Kandaurov4-8/+20
It doesn't make sense to expose the header type in a public function.
2020-11-17QUIC: refactored long header parsing.Sergey Kandaurov3-93/+50
The largely duplicate type-specific functions ngx_quic_parse_initial_header(), ngx_quic_parse_handshake_header(), and a missing one for 0-RTT, were merged. The new order of functions listed in ngx_event_quic_transport.c reflects this. |_ ngx_quic_parse_long_header - version-invariant long header fields \_ ngx_quic_supported_version - a helper to decide we can go further \_ ngx_quic_parse_long_header_v1 - QUICv1-specific long header fields 0-RTT packets previously appeared as Handshake are now logged as appropriate: *1 quic packet rx long flags:db version:ff00001d *1 quic packet rx early len:870 Logging SCID/DCID is no longer duplicated as were seen with Initial packets.
2020-11-17QUIC: sorted header parsing functions in order of appearance.Sergey Kandaurov1-164/+164
No functional changes.
2020-11-17QUIC: removed macros for stream limits unused since c5324bb3a704.Sergey Kandaurov1-3/+0
2020-11-13Core: hide "struct ngx_quic_connection_s" and further reduce diffs.Sergey Kandaurov2-21/+20
As with the previous change, it became feasible with feec2cc762f6 that removes ngx_quic_connection_t from ngx_connection_s.
2020-11-13Core: reduced diff to the default branch.Sergey Kandaurov1-4/+4
It became feasible to reduce after feec2cc762f6 that removes ngx_quic_connection_t from ngx_connection_s.
2020-11-13QUIC: microoptimization in varint parsing.Sergey Kandaurov1-1/+1
Removed a useless mask from the value being shifted, since it is 1-byte wide.
2020-11-10Fixed generating chunked response after 46e3542d51b3.Roman Arutyunyan1-19/+26
If trailers were missing and a chain carrying the last_buf flag had no data in it, then last HTTP/1 chunk was broken. The problem was introduced while implementing HTTP/3 response body generation. The change fixes the issue and reduces diff to the mainline nginx.
2020-11-11QUIC: generate default stateless reset token key.Roman Arutyunyan5-27/+41
Previously, if quic_stateless_reset_token_key was empty or unspecified, initial stateless reset token was not generated. However subsequent tokens were generated with empty key, which resulted in error with certain SSL libraries, for example OpenSSL. Now a random 32-byte stateless reset token key is generated if none is specified in the configuration. As a result, stateless reset tokens are now generated for all server ids.
2020-11-11QUIC: removed comment.Roman Arutyunyan1-1/+0
2020-11-11QUIC: added quic_stateless_reset_token_key Stream directive.Roman Arutyunyan1-0/+10
A similar directive is already available in HTTP.
2020-11-11QUIC: reallocate qc->dcid on retry.Roman Arutyunyan1-0/+6
Previously new dcid was generated in the same memory that was allocated for qc->dcid when creating the QUIC connection. However this memory was also referenced by initial_source_connection_id and retry_source_connection_id transport parameters. As a result these parameters changed their values after retry which broke the protocol.
2020-11-10QUIC: renamed c->qs to c->quic.Roman Arutyunyan16-46/+46
2020-11-10QUIC: got rid of the c->quic field.Roman Arutyunyan3-147/+179
Now QUIC connection is accessed via the c->udp field.
2020-11-11QUIC: connection multiplexing per port.Roman Arutyunyan7-100/+549
Also, connection migration within a single worker is implemented.
2020-11-10Configure: shared sources for addon modules.Maxim Dounin3-3/+45
Addon modules, both dynamic and static, can now use shared source files. Shared sources result in only one make rule even if specified several times in different modules.
2020-11-10Configure: initialization of NGX_ADDON_SRCS.Maxim Dounin1-0/+1
2020-11-10Configure: style.Maxim Dounin1-5/+5
2020-11-09Request body: removed error assumption (ticket #2058).Maxim Dounin1-2/+3
Before introduction of request body filter in 42d9beeb22db, the only possible return code from the ngx_http_request_body_filter() call without actual buffers was NGX_HTTP_INTERNAL_SERVER_ERROR, and the code in ngx_http_read_client_request_body() hardcoded the only possible error to simplify the code of initial call to set rb->rest. This is no longer true after introduction of request body filters though, as a request body filter might need to return other errors, such as 403. Fix is to preserve the error code actually returned by the call instead of assuming 500.
2020-11-09Request body: improved logging.Maxim Dounin1-0/+3
Added logging before returning NGX_HTTP_INTERNAL_SERVER_ERROR if there are busy buffers after a request body flush. This should never happen with current code, though bugs can be introduced by 3rd party modules. Make sure debugging will be easy enough.
2020-11-09QUIC: renamed field and function related to client ids.Roman Arutyunyan1-8/+8
Particularly, c->curr_seqnum is renamed to c->client_seqnum and ngx_quic_alloc_connection_id() is renamed to ngx_quic_alloc_client_id().
2020-11-10QUIC: multiple versions support in ALPN.Sergey Kandaurov5-14/+43
Previously, a version based on NGX_QUIC_DRAFT_VERSION was always set. Now it is taken from the negotiated QUIC version that may differ.
2020-11-10QUIC: multiple versions support.Sergey Kandaurov3-6/+14
Draft-29 and beyond are now treated as compatible versions.
2020-11-10QUIC: preparatory changes for multiple QUIC versions support.Sergey Kandaurov2-3/+32
A negotiated version is decoupled from NGX_QUIC_VERSION and, if supported, now stored in c->quic->version after packets processing. It is then used to create long header packets. Otherwise, the list of supported versions (which may be many now) is sent in the Version Negotiation packet. All packets in the connection are expected to have the same version. Incoming packets with mismatched version are now rejected.
2020-11-06SSL: fixed non-working SSL shutdown on lingering close.Ruslan Ermilov3-17/+65
When doing lingering close, the socket was first shut down for writing, so SSL shutdown initiated after lingering close was not able to send the close_notify alerts (ticket #2056). The fix is to call ngx_ssl_shutdown() before shutting down the socket.
2020-11-06Removed dead code from ngx_http_set_keepalive().Ruslan Ermilov1-7/+0
The code removed became dead after 98f03cd8d6cc (0.8.14), circa when the request reference counting was introduced.
2020-11-06QUIC: added proper logging of special values.Vladimir Homutov1-8/+8
A number of unsigned variables has a special value, usually -1 or some maximum, which produces huge numeric value in logs and makes them hard to read. In order to distinguish such values in log, they are casted to the signed type and printed as literal '-1'.
2020-11-02QUIC: fixed address validation issues in a new connection.Sergey Kandaurov1-2/+13
The client address validation didn't complete with a valid token, which was broken after packet processing refactoring in d0d3fc0697a0. An invalid or expired token was treated as a connection error. Now we proceed as outlined in draft-ietf-quic-transport-32, section 8.1.3 "Address Validation for Future Connections" below, which is unlike validating the client address using Retry packets. When a server receives an Initial packet with an address validation token, it MUST attempt to validate the token, unless it has already completed address validation. If the token is invalid then the server SHOULD proceed as if the client did not have a validated address, including potentially sending a Retry. The connection is now closed in this case on internal errors only.
2020-11-02QUIC: refactored key handling.Sergey Kandaurov5-167/+191
All key handling functionality is moved into ngx_quic_protection.c. Public structures from ngx_quic_protection.h are now private and new methods are available to manipulate keys. A negotiated cipher is cached in QUIC connection from the set secret callback to avoid calling SSL_get_current_cipher() on each encrypt/decrypt operation. This also reduces the number of unwanted c->ssl->connection occurrences.
2020-10-29QUIC: refactored SSL_do_handshake() handling.Sergey Kandaurov1-38/+42
No functional changes.
2020-10-29QUIC: passing ssl_conn to SSL_get0_alpn_selected() directly.Sergey Kandaurov1-1/+1
No functional changes.
2020-10-29Merged with the default branch.Sergey Kandaurov21-70/+582
2020-10-29QUIC: handle more frames in ngx_quic_resend_frames().Roman Arutyunyan1-0/+58
When a packet is declared lost, its frames are handled differently according to 13.3. Retransmission of Information.
2020-10-28QUIC: avoided retransmission of stale ack frames.Vladimir Homutov1-3/+14
Acknowledgments are regenerated using the most recent data available.
2020-10-28Core: added format specifiers to output binary data as hex.Vladimir Homutov4-67/+86
Now "s", "V", and "v" format specifiers may be prefixed with "x" (lowercase) or "X" (uppercase) to output corresponding data in hexadecimal format. In collaboration with Maxim Dounin.
2020-11-05Version bump.Vladimir Homutov1-2/+2
generated by cgit (git 2.34.1) at 2025-12-17 15:21:27 +0000