summaryrefslogtreecommitdiffhomepage
path: root/src/core/ngx_conf_file.c
diff options
context:
space:
mode:
authorMaxim Dounin <mdounin@mdounin.ru>2013-02-10 03:55:18 +0000
committerMaxim Dounin <mdounin@mdounin.ru>2013-02-10 03:55:18 +0000
commitb217a2a46705b3fc6eb939fe112e5145ae263135 (patch)
tree59f2d86792cc9ce20081a2a7991113d94b8153bb /src/core/ngx_conf_file.c
parentad72db49c01a9b7bfa16199c7e4760000286790d (diff)
downloadnginx-b217a2a46705b3fc6eb939fe112e5145ae263135.tar.gz
nginx-b217a2a46705b3fc6eb939fe112e5145ae263135.tar.bz2
Merge of r4967: ngx_write_fd() and ngx_read_fd() errors handling.
The ngx_write_fd() and ngx_read_fd() functions return -1 in case of error, so the incorrect comparison with NGX_FILE_ERROR (which is 0 on windows platforms) might result in inaccurate error message in the error log. Also the ngx_errno global variable is being set only if the returned value is -1.
Diffstat (limited to 'src/core/ngx_conf_file.c')
-rw-r--r--src/core/ngx_conf_file.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/ngx_conf_file.c b/src/core/ngx_conf_file.c
index 6da2dae80..12bb5cf8a 100644
--- a/src/core/ngx_conf_file.c
+++ b/src/core/ngx_conf_file.c
@@ -983,7 +983,7 @@ ngx_conf_flush_files(ngx_cycle_t *cycle)
n = ngx_write_fd(file[i].fd, file[i].buffer, len);
- if (n == NGX_FILE_ERROR) {
+ if (n == -1) {
ngx_log_error(NGX_LOG_ALERT, cycle->log, ngx_errno,
ngx_write_fd_n " to \"%s\" failed",
file[i].name.data);