diff options
| author | Maxim Dounin <mdounin@mdounin.ru> | 2021-03-05 17:16:15 +0300 |
|---|---|---|
| committer | Maxim Dounin <mdounin@mdounin.ru> | 2021-03-05 17:16:15 +0300 |
| commit | d5a31fdad50dbd28974cb0eb7f23948241a7559e (patch) | |
| tree | 859901108dc39b8c4f5b123c4e2443928bd50433 | |
| parent | 797ac536fe2cc0a311a72ddb861784f320991beb (diff) | |
| download | nginx-d5a31fdad50dbd28974cb0eb7f23948241a7559e.tar.gz nginx-d5a31fdad50dbd28974cb0eb7f23948241a7559e.tar.bz2 | |
Events: fixed eventport handling in ngx_handle_read_event().
The "!rev->ready" test seems to be a typo, introduced in the original
commit (719:f30b1a75fd3b). The ngx_handle_write_event() code properly
tests for "rev->ready" instead.
Due to this typo, read events might be unexpectedly removed during
proxying after an event on the other part of the proxied connection.
Catched by mail proxying tests.
| -rw-r--r-- | src/event/ngx_event.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/event/ngx_event.c b/src/event/ngx_event.c index 402a7f5e2..ed7b30bf3 100644 --- a/src/event/ngx_event.c +++ b/src/event/ngx_event.c @@ -318,7 +318,7 @@ ngx_handle_read_event(ngx_event_t *rev, ngx_uint_t flags) return NGX_OK; } - if (rev->oneshot && !rev->ready) { + if (rev->oneshot && rev->ready) { if (ngx_del_event(rev, NGX_READ_EVENT, 0) == NGX_ERROR) { return NGX_ERROR; } |