nginx.git/src/http/modules/ngx_http_geoip_module.c, branch release-1.29.2

Fixed undefined behaviour with IPv4-mapped IPv6 addresses.

2024-03-18T13:14:30+00:00

Previously, it could result when left-shifting signed integer due to implicit
integer promotion, such that the most significant bit appeared on the sign bit.

In practice, though, this results in the same left value as with an explicit
cast, at least on known compilers, such as GCC and Clang.  The reason is that
in_addr_t, which is equivalent to uint32_t and same as "unsigned int" in ILP32
and LP64 data type models, has the same type width as the intermediate after
integer promotion, so there's no side effects such as sign-extension.  This
explains why adding an explicit cast does not change object files in practice.

Found with UndefinedBehaviorSanitizer (shift).

Based on a patch by Piotr Sikora.

Reworked multi headers to use linked lists.

2022-05-30T18:25:33+00:00

Multi headers are now using linked lists instead of arrays.  Notably,
the following fields were changed: r->headers_in.cookies (renamed
to r->headers_in.cookie), r->headers_in.x_forwarded_for,
r->headers_out.cache_control, r->headers_out.link, u->headers_in.cache_control
u->headers_in.cookies (renamed to u->headers_in.set_cookie).

The r->headers_in.cookies and u->headers_in.cookies fields were renamed
to r->headers_in.cookie and u->headers_in.set_cookie to match header names.

The ngx_http_parse_multi_header_lines() and ngx_http_parse_set_cookie_lines()
functions were changed accordingly.

With this change, multi headers are now essentially equivalent to normal
headers, and following changes will further make them equivalent.

Variables: macros for null variables.

2017-08-01T11:28:33+00:00

No functional changes.

GeoIP: not all variable fields were initialized.

2014-07-25T21:43:29+00:00

The ngx_http_geoip_city_float_variable and
ngx_http_geoip_city_int_variable functions did not always initialize
all variable fields like "not_found", which could lead to empty values
for those corresponding nginx variables randomly.

Style: remove whitespace between function name and parentheses.

2014-07-08T10:03:14+00:00

Signed-off-by: Piotr Sikora

Correctly handle multiple X-Forwarded-For headers (ticket #106).

2013-02-27T13:29:50+00:00

GeoIP: removed pseudo-support of "proxy" and "netspeed" databases.

2013-02-04T16:44:22+00:00

GeoIP: IPv6 support.

2013-01-24T16:15:51+00:00

When using IPv6 databases, IPv4 addresses are looked up as IPv4-mapped
IPv6 addresses.

Mostly based on a patch by Gregor Kališnik (ticket #250).

Fixed strict aliasing bugs when dealing with IPv4-mapped IPv6 addresses

2012-08-30T14:58:11+00:00

(closes #201).

geoip: got rid of ugly casts when calling ngx_free().

2012-05-29T09:19:51+00:00

This is done by removing the "const" qualifier from the common return
type of handler functions returning either "const char *" or "char *".